url.format prefers host over hostname, but http.request does the opposite #2277
Labels
http
Issues or PRs related to the http subsystem.
semver-major
PRs that contain breaking changes and should be released in the next major version.
stalled
Issues and PRs that are stalled.
url
Issues and PRs related to the legacy built-in url module.
I noticed this when working on #2271 - regardless of which one you think should "win", you'd expect the last two lines here to end up with the same url:
To node/io.js's credit, they are both documented correctly, but that only goes so far.
I don't really care which one wins (I suppose I'd pick
hostname
if I had to choose), but I think we should consider making a breaking change at some point in order to make those two APIs more consistent.(Getters and setters on Url objects would help, but I could imagine someone doing this to a regular Object as well, so I still think the APIs should be consistent.)
The text was updated successfully, but these errors were encountered: