-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Buffer
doesn't support usc-2
, but Buffer.isEncoding
supports that?!
#21963
Labels
buffer
Issues and PRs related to the buffer subsystem.
Comments
ghost
changed the title
[Bug] Jul 25, 2018
Buffer
doesn't support usc-2
, but Buffer.isEncoding
supports that?!Buffer
doesn't support usc-2
, but Buffer.isEncoding
supports that?!
@nodejs/buffer |
what is |
@devsnek:Not sure why we have this encoding? Now check this following in 10.7.0: And should I help you to remove that in Waiting for your response :) |
@mscdex :thanks anyway! |
mscdex
added a commit
to mscdex/io.js
that referenced
this issue
Jul 25, 2018
/ping @addaleax @joyeecheung |
targos
pushed a commit
that referenced
this issue
Jul 31, 2018
Fixes: #21963 PR-URL: #21964 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nodejs:10.7.0
OS:Win 8.1 (SP1, x32)
If you use
Buffer.isEncoding('usc-2')
, this will return youtrue
.However, most of
Buffer
methods are NOT supporting this encoding. A typical example is (either of them will throw exceptions):Is there anything conflicting with the encoding type?
The text was updated successfully, but these errors were encountered: