Skip to content

make distclean removes version-controlled files #21163

Closed
@Trott

Description

@Trott
  • Version: 11.0.0-pre (master)
  • Platform: POSIX
  • Subsystem: build
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working tree clean
$ make distclean
rm -f -r out
rm -f config.gypi icu_config.gypi config_fips.gypi
rm -f config.mk
rm -f -r node node_g
rm -f -r node_modules
rm -f -r deps/icu
rm -f -r deps/icu4c*.tgz deps/icu4c*.zip deps/icu-tmp
rm -f node-v11.0.0-darwin-x64.tar.* node-v11.0.0.tar.*
rm -f -r deps/v8/testing/gmock
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	deleted:    deps/v8/testing/gmock/BUILD.gn
	deleted:    deps/v8/testing/gmock/OWNERS
	deleted:    deps/v8/testing/gmock/include/DEPS
	deleted:    deps/v8/testing/gmock/include/gmock/gmock-actions.h
	deleted:    deps/v8/testing/gmock/include/gmock/gmock-generated-function-mockers.h
	deleted:    deps/v8/testing/gmock/include/gmock/gmock-matchers.h
	deleted:    deps/v8/testing/gmock/include/gmock/gmock.h

no changes added to commit (use "git add" and/or "git commit -a")
$ 

I'm not sure if the right solution is to change the Makefile so it doesn't delete those files, or if the right solution is to remove those files from version control. I'm guessing it's the former, but maybe they get generated? (If I had compilation working on my machine right now, I'd test/check.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions