Missing exports : TLSv1_2_client_method, TLSv1_2_server_method

[d3x0r]

Version: 10.0.0
Platform: Win32-x64
Subsystem:

TLSv1_2_client_method and TLSv1_2_server_method are not exported.

there is TLS_client_method() and TLS_server_method(); but then node versions previous to 10 don't export that, but instead export the previous methods.

As a workaround - going to investigate a node version definition to #ifdef the code.

[addaleax]

Just for clarity: What you are saying is that these symbols are not available to addons on Windows when they should be?

[d3x0r]

They previously were available, so addons can link to and use the same version of OpenSSL as node.

---

Edit: very annoying to workaround; the code that links against most of OpenSSL doesn't itself know about node.h (node_version.h) and it's not an issue with OpenSSL itself; that and I no longer get to control 'only 1.2' instead of 'best available'

Edit2: Node-gyp doesn't seem to have/get the node version to pass to projects; I can get that with cmake-js but was trying to support both (for those that don't have cmake for some odd reason). So I can't even pass it a define when compiling to specify the NODE_MAJOR_VERSION.

[bnoordhuis]

Should be easy to fix. @d3x0r Does this patch work for you?

diff --git a/node.gyp b/node.gyp
index ba65eafee9..694c3e86d6 100644
--- a/node.gyp
+++ b/node.gyp
@@ -594,7 +594,7 @@
               # Categories to export.
               '-CAES,BF,BIO,DES,DH,DSA,EC,ECDH,ECDSA,ENGINE,EVP,HMAC,MD4,MD5,'
               'PSK,RC2,RC4,RSA,SHA,SHA0,SHA1,SHA256,SHA512,SOCK,STDIO,TLSEXT,'
-              'FP_API',
+              'FP_API,TLS1_2_METHOD',
               # Defines.
               '-DWIN32',
               # Symbols to filter from the export list.

[bnoordhuis]

@d3x0r Any luck with that patch?

[d3x0r]

Applied to version tagged 10.0.0
And ... I dunno; it's not building.

  v8_inspector_copy_protocol_to_intermediate_folder
  cp: cannot create regular file `H:\\dev2\\node\\Release\\obj\\global_intermediate/deps\\v8\\src\\inspector\\js_protocol.pdl': No such file or directory
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [H:\dev2\n
ode\v8_inspector_compress_protocol_json.vcxproj]
  v8_libbase.vcxproj -> H:\dev2\node\Release\lib\v8_libbase.lib
  v8_libplatform.vcxproj -> H:\dev2\node\Release\lib\v8_libplatform.lib
  v8_libsampler.vcxproj -> H:\dev2\node\Release\lib\v8_libsampler.lib
  zlib.vcxproj -> H:\dev2\node\Release\lib\zlib.lib
Attempting to cancel the build...
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(1074,5): error MSB6006: "Lib.exe" exited with code -1073741510.
 [H:\dev2\node\deps\openssl\openssl.vcxproj]
Terminate batch job (Y/N)?
^C

H:\dev2\node>dir release\obj\global_intermediate\deps\
The system cannot find the file specified.

even cleaned everything from old builds so it would build clean... but no joy; I don't know.

if you can get a node 10.0.0 to build; the node.lib should contain

TLSv1_2_server_method TLSv1_2_client_method

should be able to be found in clear text

[addaleax]

@d3x0r I’m not sure but that might be caused by 2b85127. Can you revert that locally and try again? I don’t understand why it would fail for you but not in CI, but there’s a decent chance it’s causing that issue

[d3x0r]

• 2018-04-24
  committed 5 days ago (I think that is after the tag I have?) Commits on Apr 27, 2018

That's after V10.0.0 tag.

SHA-1: cf41627

• 2018-04-24, Version 10.0.0 (Current)

I guess it's not that long ago; I can just build against head...

[addaleax]

@d3x0r Yes, might even be the case that that fixes the problem for you then. 😄 The patch completely changed the mechanism of the copy operation that’s failing there, so I just thought it would be related to that

[d3x0r]

Yes that change restores the two missing methods that I know of :) (clicked wrong button close and commented)