mips failures for parallel/test-buffer-write(float|double)

[kapouer]

When building nodejs 10.0.0 on this debian build server
these tests fail:
parallel/test-buffer-writefloat
parallel/test-buffer-writedouble

full log here

[kapouer]

Other logs are available here. It is probably worth waiting the mipsel build before investigating.

[kapouer]

Two other tests fail on mips arch:
sequential/test-performance
parallel/test-cli-node-options

(all failures related to eslint are because there's no eslint module around).

[richardlau]

(all failures related to eslint are because there's no eslint module around).

Looks like we missed some tests in #18807.

[richardlau]

#20372 should address the eslint failures.

[BridgeAR]

@kapouer would you be so kind and run this once for me on mips and show me the output:

const buffer = Buffer.alloc(8);
buffer.writeDoubleBE(NaN, 0);
console.log(buffer);

[kapouer]

Unfortunately i can't run the code on the same server, i can have access only to that server. Where it results in (for both node 8.11 and 10.0):

> const buffer = Buffer.alloc(8);
undefined
> buffer.writeDoubleBE(NaN, 0);
8
> console.log(buffer);
<Buffer 7f f7 ff ff ff ff ff ff>

[BridgeAR]

@kapouer thanks a lot. Fix incoming.

[BridgeAR]

Now there is only the CLI test that should still fail. The question is what option it is that is not implemented. I guess it is --perf-prof. @kapouer would you mind checking that out?

[kapouer]

Sure ! Indeed --perf-prof breaks with

node --perf-prof
#
# Fatal error in , line 0
# unimplemented code
#
#
#
#FailureMessage Object: 0x7f97d284Trace/breakpoint trap

[BridgeAR]

@kapouer would you be so kind and test the tests with #20377 applied? All but the eslint tests should pass with that patch.

[kapouer]

@BridgeAR both failures (buffer NaN and --perf-prof) fail on mipsel too when testing with nodejs 8.11.

[BridgeAR]

With the NaN failures I guess you mean the value is represented as <Buffer 7f f7 ff ff ff ff ff ff>? That is expected and has something to do with mips and not with Node.js. We just have to fix the test again.