v9.x ParserIncomingMessage is not a constructor #20241
Description
- Version: v9.11.1
- Platform: Linux
- Subsystem: http
Works in v8.11.1
The same code run in v8.11.1 has been tested without issue
Broken in v9.11.1
This is the error message I get. I tried back to v9.9.0 with the same error.
TypeError: ParserIncomingMessage is not a constructor
at HTTPParser.parserOnHeadersComplete (_http_common.js:81:21)
at socketOnData (_http_server.js:472:20)
at Socket.emit (events.js:180:13)
at addChunk (_stream_readable.js:274:12)
at readableAddChunk (_stream_readable.js:249:11)
at Socket.Readable.unshift (_stream_readable.js:223:10)
at /root/tunnel-server.js/wstunneld.js:502:14
at process._tickCallback (internal/process/next_tick.js:176:11)
The surrounding internal node code looks like this:
_http_common.js:81
parser.incoming = new ParserIncomingMessage(parser.socket);
^
The reason this rarely used API call was run into was due to code that inspects a tcp connection before manually pushing it through either a TLS or HTTP connection:
function onTcpConnection(conn) {
conn.once('data', function (firstChunk) {
// defer after return (instead of being in many places)
process.nextTick(function () {
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
//// The offending line:
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
conn.unshift(firstChunk);
});
// https://github.com/mscdex/httpolyglot/issues/3#issuecomment-173680155
if (22 === firstChunk[0]) {
// TLS
service = 'https';
servername = (sni(firstChunk)||'').toLowerCase();
console.log("tls hello servername:", servername);
tryTls();
return;
}
if (firstChunk[0] > 32 && firstChunk[0] < 127) {
str = firstChunk.toString();
m = str.match(/(?:^|[\r\n])Host: ([^\r\n]+)[\r\n]*/im);
servername = (m && m[1].toLowerCase() || '').split(':')[0];
console.log('servername', servername);
if (/HTTP\//i.test(str)) {
service = 'http';
// TODO disallow http entirely
// /^\/\.well-known\/acme-challenge\//.test(str)
if (/well-known/.test(str)) {
// HTTP
if (Devices.exist(deviceLists, servername)) {
pipeWs(servername, service, conn, Devices.next(deviceLists, servername));
return;
}
copts.handleHttp(servername, conn);
}
else {
// redirect to https
copts.handleInsecureHttp(servername, conn);
}
return;
}
}
});
}