n-api - failure in node-addon-api testing after change in node core

[mhdawson]

• Version: master
• Platform: all
• Subsystem: n-api

We are seeing the following failure:

https://ci.nodejs.org/job/node-test-node-addon-api/MACHINE=fedora-last-latest-x64/237/console

All tests passed!
/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node[26239]: ../src/node_api.cc:466:static void {anonymous}::v8impl::Reference::FinalizeCallback(const v8::WeakCallbackInfo<{anonymous}::v8impl::Reference>&): Assertion `(((reference->_env))->open_handle_scopes) == (open_handle_scopes)' failed.
 1: node::Abort() [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 2: 0x90170b [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 3: 0x90dbea [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 4: v8::internal::GlobalHandles::DispatchPendingPhantomCallbacks(bool) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 5: v8::internal::GlobalHandles::PostGarbageCollectionProcessing(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 6: v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 7: 0xe72f68 [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 8: v8::internal::Heap::CollectAllGarbage(int, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
 9: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
10: 0xb4199f [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
11: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node]
12: 0x3c65c870427d
Tests aborted with SIGABRT
npm ERR! Test failed.  See above for more details.
Build step 'Conditional steps (multiple)' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com gabriel.schulhof@intel.com Arunesh.Chandra@microsoft.com
Notifying upstream projects of job completion
Finished: FAILURE

I think the most likely candidate is: #19537
@gabrielschulhof can you take a look.

[gabrielschulhof]

Looks like the C++ wrapper implementation of the finalize callback is failing to close the handle scope.

…

On Thu, Mar 29, 2018 at 9:02 AM, Michael Dawson ***@***.***> wrote: - *Version*: master - *Platform*: all - *Subsystem*: n-api We are seeing the following failure: https://ci.nodejs.org/job/node-test-node-addon-api/ MACHINE=fedora-last-latest-x64/237/console All tests passed! /home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node[26239]: ../src/node_api.cc:466:static void {anonymous}::v8impl::Reference::FinalizeCallback(const v8::WeakCallbackInfo<{anonymous}::v8impl::Reference>&): Assertion `(((reference->_env))->open_handle_scopes) == (open_handle_scopes)' failed. 1: node::Abort() [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 2: 0x90170b [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 3: 0x90dbea [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 4: v8::internal::GlobalHandles::DispatchPendingPhantomCallbacks(bool) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 5: v8::internal::GlobalHandles::PostGarbageCollectionProcessing(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 6: v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 7: 0xe72f68 [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 8: v8::internal::Heap::CollectAllGarbage(int, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 9: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 10: 0xb4199f [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 11: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [/home/iojs/build/workspace/node-test-node-addon-api/MACHINE/fedora-last-latest-x64/node-v10.0.0-nightly20180328bc690e9ef5-linux-x64/bin/node] 12: 0x3c65c870427d Tests aborted with SIGABRT npm ERR! Test failed. See above for more details. Build step 'Conditional steps (multiple)' marked build as failure Sending e-mails to: ***@***.*** ***@***.*** ***@***.*** Notifying upstream projects of job completion Finished: FAILURE I think the most likely candidate is: #19537 <#19537> @gabrielschulhof <https://github.com/gabrielschulhof> can you take a look. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19673>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7k0XsCr-n8Olud1Bx1OvmEH-mdWAavks5tjNtngaJpZM4TASnO> .

[gabrielschulhof]

No, my previous modification is actually failing to heed the comment whereby it's inadvisable to access fields of a Reference instance after the finalize_callback has been called, because the callback might actually destroy the Reference.

[mhdawson]

@gabrielschulhof are you working on a fix? Would like to get the node-add-api tests back to green so may take a look if you are not going to have time this week.

[gabrielschulhof]

@mhdawson I'm about to land #19718.

[gabrielschulhof]

@mhdawson I actually have to let it sit for another day, because it's only been two days since I posted the PR.

[mhdawson]

@gabrielschulhof thanks, ci is green again :)