PSA: custom git command for landing PRs

[joyeecheung]

node-core-utils v1.9.0 has been released with a custom git command called git-node, which can fetch a PR, check its state, apply the patches, generate the necessary metadata, amend the commit message, and verify the commits.

To land a PR with a single commit you can usually just go with pressing enter until it's complete. To land a PR with multiple commits you can use the command in conjunction with git rebase and friends.

Watch the demos:

1. Landing multiple commits: https://asciinema.org/a/148627
2. Landing one commit: https://asciinema.org/a/157445

This has just gone out with little tests (WIP), although I have been using it from my branch for more than two months and it seems to be working pretty well. Would love to have some feedback and see how it works in the wild!

[fhinkel]

Thanks! Does it include the checks from core-validate-commit?

[joyeecheung]

@fhinkel "git node land --final" uses core-validate-commit so that has to be installed (still trying to figure out how to bundle it inside)

[benjamingr]

I think this is definitely worth a @nodejs/collaborators ping - would probably save quite some time :)

[gibfahn]

@fhinkel "git node land --final" uses core-validate-commit so that has to be installed (still trying to figure out how to bundle it inside)

Could we just make core-validate-commit a dependency of node-core-utils (and maybe also a part of the git repo)?

[maclover7]

Very neat tool. I had built my own PR lander tool (https://github.com/maclover7/committer-tools-rb), essentially does the same thing. Really happy to see we are working on automating away lots of stuff these days :)

[ronkorving]

This is great!
Would be good to document this in https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md I reckon?

[mcollina]

neat! good work!!

[targos]

Great tool! I use it every time now :)

Should we close this issue or keep it open as a reminder to update the collaborator guide?