Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--inspect-brk does not work with ESM #17340

Closed
TimothyGu opened this issue Nov 27, 2017 · 0 comments
Closed

--inspect-brk does not work with ESM #17340

TimothyGu opened this issue Nov 27, 2017 · 0 comments
Assignees
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. inspector Issues and PRs related to the V8 inspector protocol

Comments

@TimothyGu
Copy link
Member

TimothyGu commented Nov 27, 2017

  • Version: master
  • Platform: Linux 4.9.0-4-amd64 SMP Debian 4.9.51-1 (2017-09-28) x86_64 GNU/Linux
  • Subsystem: esm, inspector

From #17336.

$ echo "console.log('abc');" > a.mjs
$ node --inspect-brk --experimental-modules a.mjs
Debugger listening on ws://127.0.0.1:9229/bd0babdd-f59c-4014-8fcf-5679cdbcdc83
For help see https://nodejs.org/en/docs/inspector
# Connect to node instance with Chrome DevTools. Then, without doing anything
# in DevTools...
Debugger attached.
(node:2995) ExperimentalWarning: The ESM module loader is experimental.
abc
Waiting for the debugger to disconnect...
@TimothyGu TimothyGu added esm Issues and PRs related to the ECMAScript Modules implementation. inspector Issues and PRs related to the V8 inspector protocol labels Nov 27, 2017
@eugeneo eugeneo self-assigned this Nov 27, 2017
MylesBorins pushed a commit that referenced this issue Feb 20, 2018
Reworked rebase of PR #17360 with feedback

PR-URL: #18194
Fixes: #17340
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Reworked rebase of PR #17360 with feedback

PR-URL: #18194
Fixes: #17340
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
Reworked rebase of PR #17360 with feedback

PR-URL: #18194
Fixes: #17340
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
Reworked rebase of PR nodejs#17360 with feedback

PR-URL: nodejs#18194
Fixes: nodejs#17340
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants