Skip to content

node-test-linter npm installs remark-cli for each build #16628

Closed
@gibfahn

Description

@gibfahn
  • Version:
  • Platform: CI
  • Subsystem: build

Look at https://ci.nodejs.org/job/node-test-linter/lastSuccessfulBuild/console

if [ ! -d tools/remark-cli/node_modules ]; then \
	cd tools/remark-cli && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.1.2 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"freebsd","arch":"x64"})

added 272 packages in 21.24s
if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \
	cd tools/remark-preset-lint-node && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi
npm notice created a lockfile as package-lock.json. You should commit this file.
added 48 packages in 4.735s
Running Markdown linter...

It's only taking 25s each time, but it seems wasteful. I know this is how Travis etc. work, so maybe this should just be closed, but I miss sub two minute lint jobs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions