Skip to content

http2: do not allow socket operations on session.socket #16252

Closed
@mcollina

Description

In http2, the session exposes a socket property. However this socket is completely managed by HTTP2 and it is exposed only for information retrieval purposes. The socket itself should not be tampered with, as it can result in unpredictable state.

In the compatibility layer, we are wrapping it in a Proxy, and we are disabling some of the problematic methods (pause(), resume(), etc). I think we should do it in the core API as well.

  • Version: master
  • Platform: all
  • Subsystem: http2

Ref: #16211

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

http2Issues or PRs related to the http2 subsystem.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions