Ctrl + C Doesn't Kill Gracefully | Node v6.11.3 - Git Bash

[dark-swordsman]

• Version: v6.11.3
• Platform: 64-bit Windows 10
• CLI: Git 2.14.1
• Express Version: 4.16.1

Referencing #4182 which seems similar (but at the end, it was stated that a new issue should be opened).

Ctrl + C does not kill the server. The resolution to the issue was using:

process.on('SIGINT', function() {
    process.exit();
});

however, when I use it, my server exits immediately. It completely skips app.listen() and exits completely, even when I previously kill the process on the specific port. Without the process.exit() function, it starts up and I can Ctrl + C to exit, but the process still runs in the background. I opened an issue on StackOverflow which hasn't gone anywhere really. This happens across multiple projects, so it's not just one project. I'm pretty sure it started happening when I updated node.

I am able to use netstat -aon to list it, then tskill <pid> to kill it afterwards, but this isn't really a solution.

Here's my code with my express server:

const express = require('express');
const app = express();

var config = require('./config')(process.env.NODE_ENV);
var appPort = process.env.PORT || config.port;

app.listen(appPort, function () {
  console.log('UAction Test Server Running on Port ' + appPort + '!');
});

process.on('SIGINT', function() {
  console.log( "\nGracefully shutting down from SIGINT (Ctrl-C)" );
  // some other closing procedures go here
  process.exit(1);
});

UPDATE
So the server is able to start now with:

process.on('SIGINT', function() {
  console.log( "\nGracefully shutting down from SIGINT (Ctrl-C)" );
  // some other closing procedures go here
  process.exit(1);
});

I added app.use('/', express.static('./src'));, but removing it didn't change anything.

When I do Ctrl + C, the console.log("\nGracefully shutting down from SIGINT (Ctrl-C)" ); doesn't appear, and trying to restart causes the same issue. Just for reference, here's the log:

$ npm start

> express-test@1.0.0 start E:\github\uaction\express-test
> node index.js

events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE :::1337
    at Object.exports._errnoException (util.js:1020:11)
    at exports._exceptionWithHostPort (util.js:1043:20)
    at Server._listen2 (net.js:1258:14)
    at listen (net.js:1294:10)
    at Server.listen (net.js:1390:5)
    at EventEmitter.listen (E:\github\uaction\express-test\node_modules\express\lib\application.js:618:24)
    at Object.<anonymous> (E:\github\uaction\express-test\index.js:9:5)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)

npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v6.11.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! express-test@1.0.0 start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the express-test@1.0.0 start script 'node index.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the express-test package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node index.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs express-test
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls express-test
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     E:\github\uaction\express-test\npm-debug.log

[refack]

Hi @dark-swordsman,

I can't repro. Is there a specific way that you start the process?

[dark-swordsman]

I start the process like any other. The package.json looks at "start": "node index.js". I use npm start to start the process. The process then starts with the following console messages:

$ npm start

> express-test@1.0.0 start E:\github\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!

I usually do Ctrl + C to exit the process, which usually gracefully kills it and it doesn't run in the background. What ends up happening is the command line returns to it's previous state:

$ npm start

> express-test@1.0.0 start E:\github\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!


DarkSwordsman@FUJIWARA_TOFU_SHOP MINGW64 /e/github/uaction/express-test (phonegap-testing)
$

Doing Ctrl + C without any process running results in a ^C being printed, which is normal behavior.

Then from there, doing npm start again (which I usually do and have done forever) results in a EADDRINUSE error (detailed above in OP).

netstat -aon shows the localhost process running with a PID (which is random every time):

$ netstat -aon

Active Connections

  Proto  Local Address          Foreign Address        State           PID
  TCP    0.0.0.0:135            0.0.0.0:0              LISTENING       1100
  TCP    0.0.0.0:445            0.0.0.0:0              LISTENING       4
  TCP    0.0.0.0:1337           0.0.0.0:0              LISTENING       8012

then tskill <pid> is used to kill it.

I did find this in the documentation, which may be relevant, but I am not sure:

"SIGTERM and SIGINT have default handlers on non-Windows platforms that resets the terminal mode before exiting with code 128 + signal number. If one of these signals has a listener installed, its default behavior will be removed (Node.js will no longer exit)."

According to that, I am not sure what I may have installed... unless it may be firebase tools? I will uninstall them temporarily and see if that fixes it, since I also changed that recently.

UPDATE
Uninstalling firebase, firebase-tools, phonegap, and cordova did not fix the issue.

[refack]

UPDATE
Uninstalling firebase, firebase-tools, phonegap, and cordova did not fix the issue.

By my guess it wouldn't be a general CLI tool but rather something that traps keystrokes like ComEnu or clink.
There are several players in you scenario:

1. minnty
2. bash
3. npm
4. node
5. conhost
6. possibly other keystroke traps

I'll try to reproduce so I can investigate, but the simplest answer I can give you, don't launch node from mintty (Ref: #16104)

[dark-swordsman]

I just tried using Node.js command prompt (A CMD with Node: "Your environment has been set up for using Node.js 6.11.3 (x64) and npm.") and it was able to successfully kill and restart the process. It also confirms if I want to Terminate batch job:

E:\GitHub\uaction\express-test>npm start

> express-test@1.0.0 start E:\GitHub\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!
Terminate batch job (Y/N)? Y

E:\GitHub\uaction\express-test>npm start

> express-test@1.0.0 start E:\GitHub\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!
Terminate batch job (Y/N)? Y

E:\GitHub\uaction\express-test>

So I can confirm that this is an issue with (at least) MinTTY, hopefully not with Git Bash completely.

I will continue to find anything that would interfere with Bash (I may start with just a clean re-install; perhaps different settings) since I would prefer not to work in CMD... Lol

EDIT: I want to mention I had Git version 2.14.1 and am going to install version 2.14.2.2 which is the latest from Git.

UPDATE: Updating to Git version 2.14.2.2 did not work. I used the following settings:

- Use Git from Git Bash only
- Use the OpenSSL Library
- Checkout Windows-style, commit Unix-style line endings
- Use MinTTY (the deafult terminal of MSYS2)

- Enable file system caching
- Enable Git Credential Manager
- Disable symbolic links

I will come back and reinstall changing from MinTTY to CMD.

[dark-swordsman]

The issue was MinTTY. I don't know why, but changing to the Default Console Window fixed the issue.

EDIT: I referenced this issue in git-for-windows/git/issues/1219 which seems to be the most relevant issue. @dscho said something about MSYS2 being modified since v2.13.1 (which is what MinTTY uses) that causes this.

Here are the settings:

- Use Git from Git Bash only
- Use the OpenSSL Library
- Checkout Windows-style, commit Unix-style line endings
- Use Default Console Window (CMD)

- Enable file system caching
- Enable Git Credential Manager
- Disable symbolic links

Here's it gracefully closing and restarting:

DarkSwordsman@FUJIWARA_TOFU_SHOP MINGW64 /e/github/uaction/express-test (phonegap-testing)
$ npm start

> express-test@1.0.0 start E:\github\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!


DarkSwordsman@FUJIWARA_TOFU_SHOP MINGW64 /e/github/uaction/express-test (phonegap-testing)
$ npm start

> express-test@1.0.0 start E:\github\uaction\express-test
> node index.js

UAction Test Server Running on Port 1337!


DarkSwordsman@FUJIWARA_TOFU_SHOP MINGW64 /e/github/uaction/express-test (phonegap-testing)
$

Everyone tells me Mac is better, and I'm starting to believe that more and more everyday, but I really don't want to fork over thousands when I already have a great working computer.

Might try ElementaryOS though. 🤔

Sorry for cluttering Node with another issue, but hopefully this will help being here since many people may think it's Node's fault like I did.

[refack]

Everyone tells me Mac is better, and I'm starting to believe that more and more everyday, but I really don't want to fork over thousands when I already have a great working computer.

There are a few of us who develop node on Windows, so it's not a completely uncharted territory. Personally I use ComEmu to run most of my shells; "Git bash", cmd, and "WSL bash", and I don't have zombie process problems.
I believe the problem you were experiencing was the shell was disconnecting from the process, but the process didn't receive the signal (similar in a sense to nohup). You could try running winpty npm start, I'm not sure but it might make sure the process dies if the tty streams are closed.

[dark-swordsman]

@refack doing that, I get an error:

DarkSwordsman@FUJIWARA_TOFU_SHOP MINGW64 /e/github/uaction/express-test (phonegap-testing)
$ winpty npm start
winpty: error: cannot start 'npm': Not found in PATH

I have never used or heard of winpty before, and searching for a solution to that error didn't return anything.

[danikane]

• git version 2.14.2.windows.3
• node version v6.11.4
• Windows 10 x64

Hi all, so I experienced the same issue lately and as indicated here zombie processes were present when launching node in the git bash terminal MinTTY - launched from the default Git Bash shortcut and from the context menu on a folder - located in C:\Program Files\Git
So I decided to use bash.exe located in C:\Program Files\Git\bin and voilà- no more zombie processes!
Then I modified the shortcut and the windows shell context menu and no more nuisances.

See the screenshot below:

Hope this helps.

[KiritoCheng]

I also met the same problem, this is the latest git bash bug, if back to the previous version can kill the process node

[martinmckenna]

chiming in here to say I'm having the same issue.

Switching away from MinTTY fixed the issue

[hottredpen]

i has same problem ,but my colleague use old git-bash version not the problem , so I use the git-bash version 2.8.1 now :)