Skip to content

Can't extend encoding by hack Buffer.isEncoding anymore #1547

Closed
@hefangshi

Description

@hefangshi

a widely used iconv library iconv-lite can extend encoding by hack Buffer.isEncoding using extendNodeEncodings

but a newly commit 8a94581 cached the Buffer.isEncoding method https://github.com/iojs/io.js/blob/master/lib/string_decoder.js#L3-L9 which made extendNodeEncodings won't work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    string_decoderIssues and PRs related to the string_decoder subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions