-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Closed
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.questionIssues that look for answers.Issues that look for answers.
Description
- Version: master
- Platform:
- Subsystem: benchmarks
Currently benchmark/http/check_is_http_token takes several hours to complete if we try to compare two different Node versions. I think we should lower the number of iterations to simplify benchmarking the whole of http.
Specifically, I propose to revert this commit 39fdf07, or to reduce the number to something in between.
This was part of #6570.
@mscdex @nodejs/benchmarking what do you think?
Metadata
Metadata
Assignees
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.questionIssues that look for answers.Issues that look for answers.