Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure in inspector/test-break-when-eval ? #14982

Closed
mhdawson opened this issue Aug 22, 2017 · 6 comments
Closed

Intermittent failure in inspector/test-break-when-eval ? #14982

mhdawson opened this issue Aug 22, 2017 · 6 comments
Assignees
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

  • Version: master
  • Platform: linux/centos
  • Subsystem: inspector

Failure in CI run for unrelated doc change:

https://ci.nodejs.org/job/node-test-commit-linux/12000/nodes=centos5-32/console

not ok 1597 inspector/test-break-when-eval
  ---
  duration_ms: 15.594
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:39584/5e08c6a9-2565-4df8-aeab-4011cd9ed4d7
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [test] Setting up a debugger
    [err] Debugger attached.
    [err] 
    [test] Breaking in the code
    [out] Ready!
    [out] 
    [test] Step over console statement and test output
    [out] 0 3
    [out] 
    Timed out waiting for matching notification (Console output matching [0,3]))
    1
  ...`
@mscdex mscdex added inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Aug 22, 2017
@Trott
Copy link
Member

Trott commented Aug 23, 2017

Uh oh, here's another one:

https://ci.nodejs.org/job/node-test-commit-linux/12004/nodes=centos5-32/console

not ok 1597 inspector/test-break-when-eval
  ---
  duration_ms: 15.536
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:40127/671264a9-152c-478d-9198-afc2c1312d50
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [test] Setting up a debugger
    [err] Debugger attached.
    [err] 
    [test] Breaking in the code
    [out] Ready!
    [out] 
    [test] Step over console statement and test output
    [out] 0 3
    [out] 
    Timed out waiting for matching notification (Console output matching [0,3]))
    1

@Trott
Copy link
Member

Trott commented Aug 23, 2017

@nodejs/v8-inspector

@eugeneo eugeneo self-assigned this Aug 24, 2017
@eugeneo
Copy link
Contributor

eugeneo commented Aug 24, 2017

Status update: I am looking into it but this seems to be an actual bug (console.log is not reported to the front end randomly) and not just a test issue. Looks like other platforms do not see this, on CentOS there was 1 failure out of 100 runs.

I don't know how long it will take to fix this... Should I mark the test flaky for now?

@Trott
Copy link
Member

Trott commented Oct 1, 2017

I saw this again today, on CentOS 5 as usual. I guess we can add this as another data point for "something is up with CentOS 5, it's EOL anyway, let's remove it from CI". See nodejs/build#898

@Trott
Copy link
Member

Trott commented Oct 4, 2017

Alas, saw this on ubuntu 1604-32:

https://ci.nodejs.org/job/node-test-commit-linux/12833/nodes=ubuntu1604-32/console

not ok 1808 inspector/test-break-when-eval
  ---
  duration_ms: 15.577
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:35244/3e7b9b63-c42e-4de8-842f-d2035367feaa
    [err] 
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [test] Setting up a debugger
    [err] Debugger attached.
    [err] 
    [test] Breaking in the code
    [out] Ready!
    [out] 
    [test] Step over console statement and test output
    [out] 0 3
    [out] 
    Timed out waiting for matching notification (Console output matching [0,3]))
    1
  ...

@maclover7 maclover7 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 25, 2017
@Trott
Copy link
Member

Trott commented Oct 18, 2018

This test is now in sequential and has a slightly different name. Seems likely it's not flaky anymore. Closeing.

@Trott Trott closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants