Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: from zzo38 via IRC - napi_finalize feedback #14138

Closed
refack opened this issue Jul 8, 2017 · 3 comments
Closed

n-api: from zzo38 via IRC - napi_finalize feedback #14138

refack opened this issue Jul 8, 2017 · 3 comments
Labels
addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API.

Comments

@refack
Copy link
Contributor

refack commented Jul 8, 2017 •
edited
Loading

  • Version: 8.1.3
  • Platform: *
  • Subsystem: n-api

comes from zzo38 on the Freenode IRC #node-dev channel:

  1. The documentation for napi_finalize does not specify the function signature to use (it can easily be looked up in the .h file, but it should probably be documented there too)
  2. Add a function to retrieve the napi_finalize function pointer for a napi_value if it exists (mainly for the purpose of doing comparison; there is not much point in calling it).
@refack refack added addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. labels Jul 8, 2017
@refack
Copy link
Contributor Author

refack commented Jul 8, 2017

/cc @nodejs/n-api

@addaleax addaleax added v8 engine Issues and PRs related to the V8 dependency. addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. and removed addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. v8 engine Issues and PRs related to the V8 dependency. labels Jul 8, 2017
@mhdawson
Copy link
Member

mhdawson commented Jul 12, 2017 •
edited
Loading

@refack thanks will take a look starting with the doc.

@cjihrig cjihrig mentioned this issue Jul 14, 2017
Merged
3 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Jul 31, 2017
@cjihrig
doc: document napi_finalize() signature
6968ead 
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@cjihrig
Copy link
Contributor

cjihrig commented Jul 31, 2017

Item 1 is done now. Item 2 is also included in #14256, so I'm going to close this issue.

@cjihrig cjihrig closed this as completed Jul 31, 2017
addaleax pushed a commit that referenced this issue Aug 1, 2017
@cjihrig @addaleax
doc: document napi_finalize() signature
fffd8f5 
Refs: #14138
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@cjihrig
doc: document napi_finalize() signature
fb41b01 
Refs: nodejs#14138
PR-URL: nodejs#14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
@cjihrig @MylesBorins
doc: document napi_finalize() signature
831de61 
Refs: #14138
Backport-PR-URL: #19447
PR-URL: #14230
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@refack @addaleax @cjihrig @mhdawson