Skip to content

test: remove unnecessary Buffer imports #13836

Closed
@aqrln

Description

We don't use the global Buffer throughout the lib/ to avoid circular dependency issues in core, and we have a custom lint rule to prevent doing so by accident. But before #5371 this rule used to be applied to the whole project instead of just lib/. Now that the rule only applies to the relevant part of the codebase, all the instances of

const Buffer = require('buffer').Buffer;

and

const { Buffer } = require('buffer');

can be safely removed from the files in the test/ directory.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bufferIssues and PRs related to the buffer subsystem.testIssues and PRs related to the tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions