Skip to content

Document the eslint update process #12611

Description

@gibfahn

See #12563 (comment)

As is, I'm OK with putting eslint-plugin-markdown into tools/eslint/node_modules as long as things break in an understandable way when the plugin is missing after an upgrade. For that matter, the upgrade process probably needs to be documented somewhere and that would be a good place to include the instructions to include the plugin. I might try to do that if I get some time today, but as always, I'd be thrilled if someone beats me to it. (I always forget a step in the upgrade anyway involving a symlink or something to .bin/eslint.js I think?

The symlink step was done in #10771 and #9299

See also #9299 (comment)

@Trott I'm not sure either. How did you create the eslint you committed? What was your sequence? We could probably figure out one that works and document in a README somewhere. Or in the next commit message. You put some effort into your commit to say what you did, but just at a high level.

cc/ @Trott @vsemozhetbyt @sam-github

Activity

  1. added
    docIssues and PRs related to Node.js documentation.
    on Apr 23, 2017
  2. added
    toolsIssues and PRs related to the tools directory.
    on Apr 23, 2017
  3. silverwind commented on Apr 24, 2017

    @silverwind
    Contributor

    What not add a make update-js-deps or similar?

  4. Trott commented on Aug 2, 2017

    @Trott
    Member

    There's now tools/update-eslint.sh. Even if you are on an OS that can't run it, it should still be useful as a step-by-step guide for updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions