new lint option on windows is missing documentation

[refack]

#11856 (review)
/cc @liusy182
New options should be documented in help line (now 420) of vcbuild.bat

[gibfahn]

This seems like a good first contribution for someone (@refack if you want to fix it yourself feel free).

[refack]

Not first! 😛

[gibfahn]

Not first!

@refack not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, normally people don't bother to raise an Issue first if it's a simple PR.

[refack]

I might, but why do you assume it'll be my first contribution 😉 Also I believe even a post-mortem code review helps the original author...

…

On Tue, Mar 21, 2017 at 1:40 PM, Gibson Fahnestock ***@***.*** > wrote: Not first! @refack <https://github.com/refack> not sure what you mean. If you're intending to fix it yourself then go for it, I assumed you weren't planning to, as normally people don't bother to raise Issues if it's a simple PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF6s0wHzxgR0RAFNHfrhnNvAgF_j4-Oks5roAt9gaJpZM4MkILV> .

[refack]

Ohh, did you mean you wanted to? Sorry 😬. Go ahead! I'm working on something else...

[gibfahn]

@refack good-first-contribution means that this would be a good first contribution for someone who hasn't contributed to node before, not that it is or has to be your first contribution. If someone wants to have a go, then the label means anyone can go ahead ahead and raise a PR. Having some easy issues with that label helps new contributors get started.

I assumed you weren't planning to raise a PR yourself, so added the tag to open it up to anybody. If you're going to fix it then great, please do!

Also I believe even a post-mortem code review helps the original author...

Agreed, not saying you shouldn't raise an issue, just that most people wouldn't bother.

And yeah, I'm following the node-gyp repo, I'm aware that this isn't your first contribution 😄

[brennemo]

I'll give this a go as a first contribution.