Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-tls-socket-close on Raspberry Pi #11912

Closed
Trott opened this issue Mar 18, 2017 · 3 comments
Closed

Investigate flaky parallel/test-tls-socket-close on Raspberry Pi #11912

Trott opened this issue Mar 18, 2017 · 3 comments
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@Trott
Copy link
Member

Trott commented Mar 18, 2017

  • Version: v8.0.0-pre
  • Platform: pi1-raspbian-wheezy
  • Subsystem: tls (test)

https://ci.nodejs.org/job/node-test-binary-arm/6752/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console

not ok 168 parallel/test-tls-socket-close
  ---
  duration_ms: 2.557
  severity: fail
  stack: |-
    events.js:184
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at exports._errnoException (util.js:1029:11)
        at TLSWrap.onread (net.js:605:26)
  ...

@nodejs/testing @jBarz
@Trott Trott added arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. labels Mar 18, 2017
@Trott
Copy link
Member Author

Trott commented Mar 18, 2017

If we can't get rid of T in this test, it might help to use common.platformTimeout() on line 23. (I want to be able to reproduce the problem before jumping to that conclusion, though.)

@Trott
Copy link
Member Author

Trott commented Mar 18, 2017 •
edited
Loading

I am able to cause this and several other timing-related problems by running the test under load. The other problems seem more common but every once in a while I get something like this:

tools/test.py -j 32 --repeat 32 test/parallel/test-tls-socket-close.js 
=== release test-tls-socket-close ===                    
Path: parallel/test-tls-socket-close
events.js:184
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:1028:11)
    at TLSWrap.onread (net.js:605:26)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-tls-socket-close.js
[00:01|% 100|+  31|-   1]: Done

EDIT: The 32 causes errors more often than not on my machine, but if you find that isn't so, try larger values.

Trott added a commit to Trott/io.js that referenced this issue Mar 19, 2017
@Trott
test: fix flaky test-tls-socket-close
5db57ca 
Replace timer/timeout race with event-based ordering, eliminating test
flakiness.

Fixes: nodejs#11912
@Trott Trott mentioned this issue Mar 19, 2017
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Mar 19, 2017

Proposed fix in #11921

@Trott Trott closed this as completed in 7bc893f Mar 22, 2017
MylesBorins pushed a commit that referenced this issue Mar 28, 2017
@Trott @MylesBorins
test: fix flaky test-tls-socket-close
9ba551f 
Replace timer/timeout race with event-based ordering, eliminating test
flakiness.

PR-URL: #11921
Fixes: #11912
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 18, 2017
@Trott @MylesBorins
test: fix flaky test-tls-socket-close
fc94564 
Replace timer/timeout race with event-based ordering, eliminating test
flakiness.

PR-URL: #11921
Fixes: #11912
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
@Trott @MylesBorins
test: fix flaky test-tls-socket-close
485bb1b 
Replace timer/timeout race with event-based ordering, eliminating test
flakiness.

PR-URL: #11921
Fixes: #11912
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@Trott @andrew749
test: fix flaky test-tls-socket-close
4882f9a 
Replace timer/timeout race with event-based ordering, eliminating test
flakiness.

PR-URL: nodejs/node#11921
Fixes: nodejs/node#11912
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-tls-socket-close Trott/io.js
1 participant
@Trott