-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
- Platform: windows
- Subsystem: test, cpplint
Implement cpplint for vcbuild.bat (i.e. a windows version of the equivalent Makefile target). Then lint can be implemented as jslint and cpplint.
See #11151 (comment).
The line in #11151 can then be updated to reflect this addition (i.e. suggest that people use vcbuild lint).
Optimistically marking this as a good first contribution as it should be a self-contained bit of Windows syntax to run tools/cpplint.py and tools/check-imports.py.
If you'd like to have a go at this then please comment here to let other people know. You can follow the guide in CONTRIBUTING.md to submit a PR.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.