Skip to content

missing #include <unicode/ustring.h> #11753

Closed
@srl295

Description

  • Subsystem: core/deps

An ICU header was missing from the #includes. This works on current ICU, but fails later when an indirect dependency changes.

diff --git a/deps/v8/src/runtime/runtime-i18n.cc b/deps/v8/src/runtime/runtime-i18n.cc
index 75e0952..c923c17 100644
--- a/deps/v8/src/runtime/runtime-i18n.cc
+++ b/deps/v8/src/runtime/runtime-i18n.cc
@@ -42,6 +42,7 @@
 #include "unicode/unistr.h"
 #include "unicode/unum.h"
 #include "unicode/uversion.h"
+#include "unicode/ustring.h"
 
 
 namespace v8 {
diff --git a/src/node_i18n.cc b/src/node_i18n.cc
index b337456..fab594c 100644
--- a/src/node_i18n.cc
+++ b/src/node_i18n.cc
@@ -43,6 +43,7 @@
 #include <unicode/ulocdata.h>
 #include <unicode/uvernum.h>
 #include <unicode/uversion.h>
+#include <unicode/ustring.h>
 
 #ifdef NODE_HAVE_SMALL_ICU
 /* if this is defined, we have a 'secondary' entry point.

Metadata

Assignees

Labels

i18n-apiIssues and PRs related to the i18n implementation.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions