Skip to content

Node fails to compile if OPENSSL_NO_NEXTPROTONEG is set #11650

Closed
@ygalblum

Description

@ygalblum
  • Version: v7.6.0 (but it is very old and exists also in v0.12.7)
  • Platform: 3.4.11-rt19 test: don't remove empty.txt on win32 #2 SMP PREEMPT Wed Mar 1 12:43:11 IST 2017 armv7l GNU/Linux
  • Subsystem: node_crypto.cc

When compiling NodeJS with an external OpenSSL library that was compiled with the flag OPENSSL_NO_NEXTPROTONEG, the compilation of node_crypto.cc fails. The reason is that instead of checking this preprocessor flag, node checks whether OPENSSL_NPN_NEGOTIATED is defined. However, the latter exists regardless to the former.
I think that the solution is replacing between the dependencies. But I cannot say for sure (if I were sure I can verify this fix, I'd offer the patch)

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.opensslIssues and PRs related to the OpenSSL dependency.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions