You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Node fails to compile if OPENSSL_NO_NEXTPROTONEG is set #11650
When compiling NodeJS with an external OpenSSL library that was compiled with the flag OPENSSL_NO_NEXTPROTONEG, the compilation of node_crypto.cc fails. The reason is that instead of checking this preprocessor flag, node checks whether OPENSSL_NPN_NEGOTIATED is defined. However, the latter exists regardless to the former.
I think that the solution is replacing between the dependencies. But I cannot say for sure (if I were sure I can verify this fix, I'd offer the patch)
The reason is that instead of checking this preprocessor flag, node checks whether OPENSSL_NPN_NEGOTIATED is defined. However, the latter exists regardless to the former.
That's right. In ssl.h, #ifndef OPENSSL_NO_NEXTPROTONEG is used for NPN feature flag so that we have to change node_crypto.cc and others. I also found ALPN test is failed when NPN is disabled. I will submit a PR to fix this.
Activity
mscdex commentedon Mar 2, 2017
/cc @nodejs/crypto
shigeki commentedon Mar 2, 2017
I will take a look at it from now.
shigeki commentedon Mar 2, 2017
That's right. In ssl.h,
#ifndef OPENSSL_NO_NEXTPROTONEGis used for NPN feature flag so that we have to change node_crypto.cc and others. I also found ALPN test is failed when NPN is disabled. I will submit a PR to fix this.shigeki commentedon Mar 2, 2017
The fix is submitted in #11655
test: fix tests when npn feature is disabled.
tls: fix macro to check NPN feature
test: fix tests when npn feature is disabled.
tls: fix macro to check NPN feature
test: fix tests when npn feature is disabled.
tls: fix macro to check NPN feature
test: fix tests when npn feature is disabled.
tls: fix macro to check NPN feature
test: fix tests when npn feature is disabled.
tls: fix macro to check NPN feature