Release proposal: v1.6.0

[rvagg]

We're starting to need a new release but we're in an awkward position of not having a good story around a semver-minor bump and there's a few issues & PRs in flux that would be good to get resolved before a release.

Note in the commit list below, the commit from #881 was reverted so no longer applies, but its resolution may be at hand so it can come back in. This would help with a 1.6.0 justification.

Also for those interested in semver arguments, please head over to #1116 and see what you think about it being semver-minor or semver-patch. It's the only thing in here that's warranting the bump to 1.6. If it wasn't for this addition then I'd have just pushed for a quick 1.5.2 and be done with this batch of commits.

So, I'm proposing a holding pattern for this release for up to 3 days to see if we can get some meat in here. Some issues worth monitoring are:

• src: command line option to preload modules #881: src: command line option to preload modules src: command line option to preload modules #881
• Possible memory leak in TLS(Wrap?) #1075: Possible memory leak in TLS(Wrap?) Possible memory leak in TLS(Wrap?) #1075
• http: allow HTTP to return an HTTPS server #1101: http: allow HTTP to return an HTTPS server http: allow HTTP to return an HTTPS server #1101
• Revert stream base #1140: Revert stream base Revert stream base #1140
• deps: upgrade npm to 2.7.1 #1142: deps: upgrade npm to 2.7.1
• [c638dad567] - benchmark: add output format option [csv] (Brendan Ashworth) #777
• [97d8d4928d] - benchmark: add plot_csv R graphing script (Brendan Ashworth) #777
• [07c066724c] - buffer: align chunks on 8-byte boundary (Fedor Indutny) #1126
• [8070b1ff99] - buffer: Don't assign .parent if none exists (Trevor Norris) #1109
• [dd37fb4c48] - build: remove incorrect argument in vcbuild.bat (Jeremiah Senkpiel) #1198
• [89bf6c05e9] - build: allow custom PackageMaker path (Julien Gilli) joyent/node#9377
• [41c9daa143] - build: fix incorrect set in vcbuild.bat (Bert Belder)
• [8b2363d2fd] - configure: use gcc and g++ as CC and CXX defaults (Ben Noordhuis) #1174
• [d8c4a932c9] - crypto: add deprecated ValiCert CA for cross cert (Shigeki Ohtsu) #1135
• [65d0a8eca8] - deps: make node-gyp work with io.js (cjihrig) #990
• [7d0baf1741] - deps: upgrade npm to 2.7.1 (Forrest L Norvell) #1142
• [2b63bcd247] - doc: add yosuke-furukawa as collaborator (Yosuke Furukawa) #1183
• [69350baaef] - doc: update test section in CONTRIBUTING.md (Ben Noordhuis) #1181
• [3c8ae2d934] - doc: add petkaantonov as collaborator (Petka Antonov) #1179
• [92c1ad97c0] - doc: add silverwind as collaborator (Roman Reiss) #1176
• [14c74d5326] - doc: add jbergstroem as collaborator (Johan Bergström) #1175
• [08ec897f82] - doc: fix typo in buffer module documentation (Alex Yursha) #1169
• [e6e616fdcb] - doc: fix '' typos on Windows (Steven Vercruysse) joyent/node#9412
• [a28945b128] - doc: reflect new require('events') behaviour (Alex Yursha) #975
• [7a5b023bac] - doc: fix vm module examples (FangDun Cai) #1147
• [d33a647b4b] - doc: make tools/update-authors.sh cross-platform (Ben Noordhuis) #1121
• [60dac07b06] - doc: add Malte-Thorben Bruns to .mailmap (Ben Noordhuis) #1118
• [80e14d736e] - doc: move checkServerIdentity option to tls.connect() (skenqbx) #1107
• [684a5878b6] - doc: fix missing periods in url.markdown (Ryuichi Okumura) #1115
• [a6af709489] - fs: use stat.st_size only to read regular files (Santiago Gimeno) #1074
• [b2e00e38dc] - (SEMVER-MINOR) http: add flushHeaders and deprecate flush (Yosuke Furukawa) #1156
• [8453fbc879] - https: don't overwrite servername option (skenqbx) #1110
• [2b2e48a4b9] - lib: don't error in repl when cwd doesn't exist (Ben Noordhuis) #1194
• [f58e59649d] - lib: remove broken NODE_MODULE_CONTEXTS feature (Ben Noordhuis) #1162
• [480b48244f] - (SEMVER-MINOR) lib: allow server.listen({ port: "1234" }) (Ben Noordhuis) #1116
• [68d4bed2fd] - make: remove node_dtrace from cpplint excludes (Julien Gilli) joyent/node#8741
• [30666f22ca] - net: use cached peername to resolve remote fields (James Hartig) joyent/node#9366
• [eb995d6822] - path: add type checking for path inputs (cjihrig) #1153
• [85a92a37ef] - querystring: optimize parse and stringify (Brian White) #847
• [1514b82355] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh) #881
• [2c6f79c08c] - src: don't error at startup when cwd doesn't exist (Ben Noordhuis) #1194
• [fe0f015c51] - src: fix crypto bio integer wraparound on 32 bits (Ben Noordhuis) #1192
• [2551c1d2ca] - src: use Number::New() for heapTotal/heapUsed (Ben Noordhuis) #1148
• [4f394998ba] - src: don't create js string twice on error (Ben Noordhuis) #1148
• [056ed4b0c9] - src: revert -r/--require flags (Chris Dickinson) #1150
• [7bde3f1a8f] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh) #881
• [e2c9040995] - src: do not leak handles on debug and exit (Fedor Indutny) #1133
• [f600111d82] - test: cache lazy properties, fix style nits (Rod Vagg) #1196
• [3038b8ee6a] - test: double timeout in tls-wrap-timeout.js (Fedor Indutny) #1201
• [c15e81afdd] - test: Introduce knowledge of FreeBSD jails (Johan Bergström) #1167
• [53e200acc2] - test: fix test-http-content-length (Jeremiah Senkpiel) #1145
• [82f067e60b] - test: fix ext commands to be double quoted (Shigeki Ohtsu) #1122
• [5ecdc0314d] - test: add test for reading a large file through a pipe (Santiago Gimeno) #1074
• [0782c24993] - test: fix readfile-zero-byte-liar test (Santiago Gimeno) #1074
• [4eb8810a27] - tls: re-enable .writev() on TLSWrap (Fedor Indutny) #1155
• [e90ed790c3] - tls: fix leak on DoWrite() errors (Fedor Indutny) #1154
• [8431fc53f1] - tls_wrap: proxy handle methods in prototype (Fedor Indutny) #1108
• [22793da485] - v8: fix --max_old_space_size=4096 integer overflow (Ben Noordhuis) #1166
• [8c4f0df464] - v8: fix build on solaris platforms (Johan Bergström) #1079

[Fishrock123]

ahhh ya beat me to it, I decided to hold off until tomorrow haha

👍

LGTM However, it may be better to wait until new release and backport.

[piscisaureus]

[7bde3f1] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh)

This patch has been reverted for now I thought?

[rvagg]

yep

[056ed4b] - src: revert -r/--require flags (Chris Dickinson) #1150

[mikeal]

• Revert stream base #1140: Revert stream base Revert stream base #1140

This should probably be a semver-major change if accepted (I don't think it will be, that issue seems to be going another way).

[brendanashworth]

A good reason for semver-minor could be #1156

[bnoordhuis]

Another one: #1162

[cjihrig]

Another semver minor: #1163. Specifically, 095ae0d.

[jameshartig]

Since 095ae0d is my commit, I'm not sure if I should chime in or not but its just making socket*() return the ip/port used even after the socket is closed. Before that commit, if the socket was closed, socket*() methods would return null.

[bnoordhuis]

@fastest963 I suggested semver-minor because it can break code that uses e.g. socket.remotePort === undefinedas an indicator of whether the socket is connected.

[jameshartig]

@bnoordhuis thanks for the clarification. Makes sense.

[rvagg]

will try and get this out tomorrow, then I guess we'll have 1.6.1 to do in a couple of days after that thanks to openssl.

[rvagg]

CI @ 2b63bcd: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/317/

RC @ 2b63bcd: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/107/ coming out at https://iojs.org/download/nightly/v1.5.2-nightly201503182b63bcd247/