-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Closed
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.httpsIssues or PRs related to the https subsystem.Issues or PRs related to the https subsystem.
Description
Agent#createSocket()
overwrites options.servername
leading to a tls.checkServerIdentity()
against hostname instead of servername.
I usually disabled connection pooling in that case, but that is not possible anymore as ClientRequest#constructor
always sets an agent.
Not sure if this is intentional; Did I overlook something in the changelog?
Metadata
Metadata
Assignees
Labels
confirmed-bugIssues with confirmed bugs.Issues with confirmed bugs.httpsIssues or PRs related to the https subsystem.Issues or PRs related to the https subsystem.