Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: track status of a spec-compliant URLSearchParams #10821

Closed
11 tasks done
TimothyGu opened this issue Jan 15, 2017 · 5 comments
Closed
11 tasks done

url: track status of a spec-compliant URLSearchParams #10821

TimothyGu opened this issue Jan 15, 2017 · 5 comments
Assignees
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@TimothyGu
Copy link
Member

TimothyGu commented Jan 15, 2017

spec:

spec irrelevant:

querystring changes:

/cc @nodejs/url

@joyeecheung
Copy link
Member

What is the Parameter order issue in the OP referring to?

@TimothyGu
Copy link
Member Author

new URLSearchParams('a=a&b=b&a=c').toString() currently returns a=a&a=c&b=b

@watilde
Copy link
Member

watilde commented Apr 10, 2017

I've updated the status of issues in https://github.com/nodejs/node/projects/5. It's a good time to re-track the current status.

@domenic
Copy link
Contributor

domenic commented Apr 10, 2017

In general I think most of the things listed as "waiting on spec" are no longer accurate and should be moved to "landed in spec".

@joyeecheung
Copy link
Member

@domenic Thanks for the reminder, I have moved those items to "landed in spec"

TimothyGu added a commit to TimothyGu/node that referenced this issue Apr 25, 2017
The entire `URLSearchParams` class is now fully spec-compliant.

PR-URL: nodejs#12507
Fixes: nodejs#10821
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
The entire `URLSearchParams` class is now fully spec-compliant.

PR-URL: #12507
Fixes: #10821
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants