Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eeb57022e6bada13955a19b15232a9ee4fe9b465
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 28e4e43e513ae90e8a4236dbae7f3442ab8dbb4f
Choose a head ref
  • 7 commits
  • 117 files changed
  • 1 contributor

Commits on Mar 25, 2018

  1. lib: always show ERR_INVALID_ARG_TYPE received part 

    This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    c6b6c92 View commit details
    Browse the repository at this point in the history

  2. lib,test: minor refactoring 

    This refactors a couple tests to have upper case first characters
in comments and to use `input` instead of `i`.
It also adds a few TODOs and rewrites a few lines to use default
arguments and to prevent function recreation when unnecessary.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    c1278e5 View commit details
    Browse the repository at this point in the history

  3. crypto: fix error handling 

    This fixes multiple cases where the wrong error was returned in
case of e.g. a overflow / wrong type.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    333adf6 View commit details
    Browse the repository at this point in the history

  4. process: fix error handling 

    This makes sure the proper error is returned. Right now the error
is not specific enough.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    058e7fb View commit details
    Browse the repository at this point in the history

  5. fs: fix error handling 

    Right now there are multiple cases where the validated entry would
not be returned or a wrong error is thrown. This fixes both cases.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    acc3c77 View commit details
    Browse the repository at this point in the history

  6. lib: improve error handling 

    This improves the error handling for a couple cases where the
received value would not have been handled so far or where the name
is wrong etc.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    b38c81c View commit details
    Browse the repository at this point in the history

  7. errors: make input mandatory 

    Using ERR_INVALID_ARG_TYPE will now require the received value as
well. This makes sure the errors are always expressive. It also
drops support for using an array as name argument.

PR-URL: #19445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @BridgeAR
    BridgeAR committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    28e4e43 View commit details
    Browse the repository at this point in the history
Loading