Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e31d1cb55da6ad9d05ed98d22164c01501ca2b39
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1dcba68534b810fb2af676121a8dc7a16285a79c
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 21, 2021

  1. test: use descriptive name for destination file 

    `http2-url-tests.js` is misleading. Use the same name of the source file
instead.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    @lpinca @nodejs-github-bot
    lpinca authored and nodejs-github-bot committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    2a8576d View commit details
    Browse the repository at this point in the history

  2. test: deflake http2-pipe-named-pipe 

    Wait for all data to be read before sending the response and closing
the client.

Fixes: #40277

PR-URL: #40842
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    @lpinca @nodejs-github-bot
    lpinca authored and nodejs-github-bot committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    4873870 View commit details
    Browse the repository at this point in the history

  3. test: fix argument order in assertion 

    The first argument is the actual value, the second argument is the
expected value.

PR-URL: #40842
Fixes: #40277
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    @lpinca @nodejs-github-bot
    lpinca authored and nodejs-github-bot committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    1dcba68 View commit details
    Browse the repository at this point in the history
Loading