Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e2a6399be742f53103474d9fc1e56fadf7f90ccc
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e239f5ea36d236776cf45098c3542376d899ce2a
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Jul 15, 2021

  1. fs: add FileHandle.prototype.readableWebStream() 

    Adds an experimental `readableWebStream()` method to `FileHandle` that
returns a web `ReadableStream`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39331
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @jasnell
    jasnell committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    6cd12be View commit details
    Browse the repository at this point in the history

  2. stream: import internal/util/types instead 

    Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39331
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @jasnell
    jasnell committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    6ad3872 View commit details
    Browse the repository at this point in the history

  3. fs: fix FileHandle::ClosePromise to return persisted Promise 

    Makes the FileHandle::ClosePromise() idempotent, always returning
the same Promise after it has already been successfully called
once. Avoids the possibility of accidental double close events.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39331
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @jasnell
    jasnell committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e239f5e View commit details
    Browse the repository at this point in the history
Loading