Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ce4718f0f406565c474790ccf8533e18ef631e13
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ecc50e9d912573eec108e143b561df219b46e183
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 21, 2017

  1. tools: remove no-useless-regex-char-class-escape 

    The `no-useless-regex-char-class-escape` custom lint rule was introduced
as a less aggressive alternative to some enhancements that were
introduced into ESLint. Those enhancements were blocking us from
updating ESLint. However, they have since been relaxed and the custom
rule is no longer needed. Remove it.

Backport-PR-URL: #14360
PR-URL: #10561
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    05b95fa View commit details
    Browse the repository at this point in the history

  2. tools: fix indentation in required-modules.js 

    In preparation for applying the more strict indentation linting
available in ESLint 4.0.0, correct minor indentation issues in
tools/eslint-rules/required-modules.js.

This is the only file with indentation that does not conform to the
stricter checks.

Backport-PR-URL: #14360
PR-URL: #13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    c52f60f View commit details
    Browse the repository at this point in the history

  3. tools: apply stricter indentation rules to tools 

    ESLint 4.0.0 provides stricter (and more granular) indentation checking
than previous versions. Apply the stricter indentation rules to the
tools directory.

Backport-PR-URL: #14360
PR-URL: #13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    4d91ff4 View commit details
    Browse the repository at this point in the history

  4. tools: fix error in custom ESLint rule 

    Fix previously-unnoticed typo in `required-modules.js`.

Backport-PR-URL: #14360
Refs: #13758 (comment)
PR-URL: #13758
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @Trott @MylesBorins
    Trott authored and MylesBorins committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    ecc50e9 View commit details
    Browse the repository at this point in the history
Loading