Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: abc87862ff14c1571f008aa1a9cbf812bea9790c
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b7cfd278a53d2b7769340ed800142f6662aa48d2
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 30, 2018

  1. net: track bytesWritten in C++ land 

    Move tracking of `socket.bytesWritten` to C++ land.

This makes it easier to provide this functionality for all
`StreamBase` instances, and in particular should keep working
when they have been 'consumed' in C++ in some way (e.g. for
the network sockets that are underlying to TLS or HTTP2 streams).

Also, this parallels `socket.bytesRead` a lot more now.

PR-URL: #19551
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    923fb5c View commit details
    Browse the repository at this point in the history

  2. test: add regression test for large write 

    Fixes: #19562

PR-URL: #19551
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    1dc8eb4 View commit details
    Browse the repository at this point in the history

  3. src: clean up req.bytes tracking 

    Simply always tell the caller how many bytes were written, rather
than letting them track it.

In the case of writing a string, also keep track of the bytes
written by the earlier `DoTryWrite()`.

Refs: #19562

PR-URL: #19551
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    b7cfd27 View commit details
    Browse the repository at this point in the history
Loading