Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9fbad51c8a6afdaf7d24d57a1712319346efe28e
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 03b5c46bc41f8ffd8d30c7902247134e091dc8e9
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 21, 2019

  1. test: improve assertion message in internet dgram test 

    When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    f04f4ae View commit details
    Browse the repository at this point in the history

  2. test: use reserved .invalid TLD for invalid address in test 

    RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    afa4f57 View commit details
    Browse the repository at this point in the history

  3. test: move test not requiring internet from internet to parallel 

    test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    03b5c46 View commit details
    Browse the repository at this point in the history
Loading