Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 98e9de7db930e505884ca8d0ca6588afbe43f127
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3d2409c476e52d0ca8729f161eedf98ece37063e
Choose a head ref
  • 5 commits
  • 47 files changed
  • 1 contributor

Commits on Apr 30, 2019

  1. deps: add acorn stage-3 plugins 

    This adds bigint, class-fields, numeric-separators, static-class
features, private class methods and fields as dependency. That way
it's possible to use these in combination with acorn to parse these
language features.

This also removes a couple of files that were not necessary for
Node.js to reduce the code base.

PR-URL: #27400
Refs: #27391
Refs: #25835
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    72c6ea2 View commit details
    Browse the repository at this point in the history

  2. assert: use new language features 

    This adds new language features to acorn. Otherwise BigInt and other
input would not be parsed correct and would not result in nice error
messages when using simple assert.

PR-URL: #27400
Refs: #27391
Refs: #25835
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    04b7c00 View commit details
    Browse the repository at this point in the history

  3. repl: add new language features to top level await statements 

    This adds stage-3 language features to acorn so that it's possible
to parse these features when using top level await in the REPL.

PR-URL: #27400
Refs: #27391
Refs: #25835
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    f37e40a View commit details
    Browse the repository at this point in the history

  4. repl: handle stage-3 language features properly 

    This adds stage-3 language features to acorn so that the REPL is
able to parse these features properly. Otherwise these would cause
SyntaxErrors.

PR-URL: #27400
Fixes: #27391
Fixes: #25835
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    e939b8f View commit details
    Browse the repository at this point in the history

  5. test: add tests for new language features 

    PR-URL: #27400
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    3d2409c View commit details
    Browse the repository at this point in the history
Loading