Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 86099a375af95f519ae699b68ce101aa20236c5f
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2aff854854dda1582ac9c29c3d2ab96e70ea735
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 1, 2021

  1. test: fix test-datetime-change-notify after daylight change 

    Add standard timezone name for Dublin without daylight saving

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    @PiotrRybak @Trott
    PiotrRybak authored and Trott committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    747ef34 View commit details
    Browse the repository at this point in the history

  2. test,tools: increase timeout for benchmark tests 

    test-benchmark-buffer is consistently timing out on a single Windows
host in CI. Rather than try to figure out if we need to scale the
timeout up for a certain memory limit or chip speed or something else,
let's increase the timeout for benchmark tests in general.

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    @Trott
    Trott committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    cbcf86f View commit details
    Browse the repository at this point in the history

  3. test,tools: increase pummel/benchmark test timeout from 4x to 6x 

    The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on
certain tests in pummel and (previously) benchmark. Increase timeout
from 4x to 6x.

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    @Trott
    Trott committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    2883992 View commit details
    Browse the repository at this point in the history

  4. test: mark test-policy-integrity flaky on Windows 

    Ref: #40694

PR-URL: #40684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    @Trott
    Trott committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b2aff85 View commit details
    Browse the repository at this point in the history
Loading