Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 61e589f8ecff12451a71bc736812004bed302f6b
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 81c03bcebd3841e5bcbd3af0a03e102b80d10d12
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Apr 13, 2020

  1. build: use same flags as V8 for ASAN 

    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: #32776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mmarchini
    mmarchini committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    2c30276 View commit details
    Browse the repository at this point in the history

  2. build: re-enable ASAN Action using clang 

    clang's linker seems to use considerably less memory than gcc, allowing
us to run on Actions without running out of memory.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: #32776
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mmarchini
    mmarchini committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    81c03bc View commit details
    Browse the repository at this point in the history
Loading