Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3d894d0511bc76c2bd886077d1cb434d878527de
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8b1efe0306c4c0ed35a271cfa9ea00033b75c6c2
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 29, 2020

  1. test: remove sequential/test-https-keep-alive-large-write.js 

    Remove a test that made a flawed assumption that a single
large buffer write can be interrupted by a timeout event.

PR-URL: #31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @rustyconover @Trott
    rustyconover authored and Trott committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    2b16c13 View commit details
    Browse the repository at this point in the history

  2. test: change test to not be sensitive to buffer send size 

    Change the test to not be sensitive to the buffer size causing
TCP resets to be received by the client causing the test to fail.
The test now reads the entire expected buffer and then checks for
the expected event to fire.

PR-URL: #31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @rustyconover @Trott
    rustyconover authored and Trott committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    35f491b View commit details
    Browse the repository at this point in the history

  3. tls: reduce memory copying and number of BIO buffer allocations 

    Avoid copying buffers before passing to SSL_write if there
are zero length buffers involved.  Only copy the data when
the buffer has a non zero length.

Send a memory allocation hint to the crypto BIO about how much
memory will likely be needed to be allocated by the next call
to SSL_write.  This makes a single allocation rather than the BIO
allocating a buffer for each 16k TLS segment written.  This
solves a problem with large buffers written over TLS triggering
V8's GC.

PR-URL: #31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @rustyconover @Trott
    rustyconover authored and Trott committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    8b1efe0 View commit details
    Browse the repository at this point in the history
Loading