Skip to content

Commit

Permalink
test: fix parameters in test-repl.js
Browse files Browse the repository at this point in the history
fixed order of parameters in assert.strictEqual() assertion functions,
first argument provided was the expected value and the second value
was the actual value.

this is backwards from the documentation for assertions like
assert.strictEqual() where the first value being tested and the second
value is the expected value

PR-URL: #23609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
binaryme authored and jasnell committed Oct 17, 2018
1 parent c160aac commit ff75d98
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,8 @@ function startTCPRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down Expand Up @@ -827,8 +827,8 @@ function startUnixRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down

0 comments on commit ff75d98

Please sign in to comment.