Skip to content

Commit feafc01

Browse files
danbevBridgeAR
authored andcommitted
build: move tooltest to before jstest target
This commit moves the tooltest target to come before the jstest target to make the console output consistent with it was before I introduced the tooltest target. Currently the output looks like this which is might give the impression that only one test was run: /Applications/Xcode.app/Contents/Developer/usr/bin/make -s tooltest . ---------------------------------------------------------------------- Ran 1 test in 0.000s Compared to the usual: [03:58|% 100|+ 2739|- 0]: Done PR-URL: #29220 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0544075 commit feafc01

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,13 @@ coverage-run-js:
313313
.PHONY: test
314314
# This does not run tests of third-party libraries inside deps.
315315
test: all ## Runs default tests, linters, and builds docs.
316+
$(MAKE) -s tooltest
316317
$(MAKE) -s test-doc
317318
$(MAKE) -s build-addons
318319
$(MAKE) -s build-js-native-api-tests
319320
$(MAKE) -s build-node-api-tests
320321
$(MAKE) -s cctest
321322
$(MAKE) -s jstest
322-
$(MAKE) -s tooltest
323323

324324
.PHONY: test-only
325325
test-only: all ## For a quick test, does not run linter or build docs.

0 commit comments

Comments
 (0)