Skip to content

Commit

Permalink
doc: ensure to revert node_version changes
Browse files Browse the repository at this point in the history
PR-URL: #44760
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
  • Loading branch information
RafaelGSS committed Sep 26, 2022
1 parent 3112d5d commit fd971f5
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -705,13 +705,17 @@ $ git pull upstream main
$ git cherry-pick v1.x^
```

Git should stop to let you fix conflicts. Revert all changes that were made to
`src/node_version.h`:
Git should stop to let you fix conflicts.

Revert all changes that were made to `src/node_version.h`:

```console
$ git checkout --ours HEAD -- src/node_version.h
```

Even if there are no conflicts, ensure that you revert all the changes that were
made to `src/node_version.h`.

If there are conflicts in `doc` due to updated `REPLACEME`
placeholders (that happens when a change previously landed on another release
branch), keep both version numbers. Convert the YAML field to an array if it is
Expand Down

0 comments on commit fd971f5

Please sign in to comment.