Skip to content

Commit

Permalink
lib,src,test: lint codebase according new rules for v18.x
Browse files Browse the repository at this point in the history
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #48697
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
juanarbol authored and danielleadams committed Jul 9, 2023
1 parent 2262653 commit fcf3781
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 14 deletions.
8 changes: 0 additions & 8 deletions lib/internal/fs/promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ const {
JSTransferable, kDeserialize, kTransfer, kTransferList,
} = require('internal/worker/js_transferable');

const {
newReadableStreamFromStreamBase,
} = require('internal/webstreams/adapters');

const {
readableStreamCancel,
} = require('internal/webstreams/readablestream');

const getDirectoryEntriesPromise = promisify(getDirents);
const validateRmOptionsPromise = promisify(validateRmOptions);

Expand Down
1 change: 0 additions & 1 deletion lib/internal/modules/esm/loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ class ESMLoader {
* until it reaches the bottom or short-circuits.
* @param {URL['href']} url The URL/path of the module to be loaded
* @param {object} context Metadata about the module
*
* @returns {{ format: ModuleFormat, source: ModuleSource }}
*/
async load(url, context = {}) {
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ignore = [
"PLC1901",
"RUF005",
"RUF100",
"RUF012",
]
line-length = 172
target-version = "py37"
Expand Down
7 changes: 4 additions & 3 deletions src/node_builtins.cc
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,10 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
return scope.Escape(fun);
}

MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
const char* id,
Environment* optional_env) {
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
Local<Context> context,
const char* id,
Environment* optional_env) {
Result result;
std::vector<Local<String>> parameters;
Isolate* isolate = context->GetIsolate();
Expand Down
2 changes: 0 additions & 2 deletions test/common/wpt.js
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,6 @@ class WPTRunner {
/**
* Report the status of each specific test case (there could be multiple
* in one test file).
*
* @param {string} filename
* @param {Test} test The Test object returned by WPT harness
*/
Expand All @@ -735,7 +734,6 @@ class WPTRunner {

/**
* Report the status of each WPT test (one per file)
*
* @param {string} filename
* @param {object} harnessStatus - The status object returned by WPT harness.
*/
Expand Down

0 comments on commit fcf3781

Please sign in to comment.