Skip to content

Commit

Permalink
doc: fix commit message using test instead of deps
Browse files Browse the repository at this point in the history
PR-URL: #46313
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
tony-go authored and juanarbol committed Mar 5, 2023
1 parent 1508d90 commit fc15ac9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ jobs:
./tools/update-undici.sh
fi
- id: postject
subsystem: deps
label: dependencies
subsystem: test
label: test
run: |
NEW_VERSION=$(npm view postject dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
Expand Down
14 changes: 7 additions & 7 deletions doc/contributing/maintaining-postject.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ Check that Node.js still builds and tests.

## Committing postject

Add postject: `git add --all test/fixtures/postject-copy`
1. Add postject: `git add --all test/fixtures/postject-copy`.
2. Commit the changes: `git commit`.
3. Add a message like:

Commit the changes with a message like:
```text
test: update postject to <version>
```text
deps: update postject to 1.0.0-alpha.4
Updated as described in doc/contributing/maintaining-postject.md.
```
Updated as described in doc/contributing/maintaining-postject.md.
```

0 comments on commit fc15ac9

Please sign in to comment.