Skip to content

Commit f8a33ab

Browse files
refacktargos
authored andcommitted
deps: V8: workaround for MSVC 14.20 optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 0a5ff4c commit f8a33ab

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.10',
41+
'v8_embedder_string': '-node.11',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/builtins/setup-builtins-internal.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,
297297

298298
} // namespace
299299

300+
#if _MSC_VER == 1920
301+
#pragma optimize( "", off )
302+
#endif
303+
300304
// static
301305
void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
302306
Builtins* builtins = isolate->builtins();
@@ -380,5 +384,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
380384
builtins->MarkInitialized();
381385
}
382386

387+
#if _MSC_VER == 1920
388+
#pragma optimize( "", on )
389+
#endif
390+
391+
383392
} // namespace internal
384393
} // namespace v8

0 commit comments

Comments
 (0)