buffer: avoid creating unnecessary environment

anonrig · aduh95 · commit f89b36eb2481 · 2025-05-06T19:12:04.000+02:00
PR-URL: #58053 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
@@ -736,11 +736,11 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {
 }
 
 void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {
-  Environment* env = Environment::GetCurrent(args);
   CHECK(args[0]->IsString());
 
   // Fast case: avoid StringBytes on UTF8 string. Jump to v8.
-  args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));
+  args.GetReturnValue().Set(
+      args[0].As<String>()->Utf8Length(args.GetIsolate()));
 }
 
 uint32_t FastByteLengthUtf8(Local<Value> receiver,

Original file line number	Diff line number	Diff line change
`@@ -736,11 +736,11 @@ void StringWrite(const FunctionCallbackInfo<Value>& args) {`
`736`	`736`	`}`
`737`	`737`
`738`	`738`	`void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {`
`739`		`- Environment* env = Environment::GetCurrent(args);`
`740`	`739`	`CHECK(args[0]->IsString());`
`741`	`740`
`742`	`741`	`// Fast case: avoid StringBytes on UTF8 string. Jump to v8.`
`743`		`- args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));`
	`742`	`+ args.GetReturnValue().Set(`
	`743`	`+ args[0].As<String>()->Utf8Length(args.GetIsolate()));`
`744`	`744`	`}`
`745`	`745`
`746`	`746`	`uint32_t FastByteLengthUtf8(Local<Value> receiver,`