Skip to content

Commit

Permalink
deps: revert whitespace changes on V8
Browse files Browse the repository at this point in the history
While landing the upgrade to V8 8.1, something went wrong and git made
unecessary (and incorrect) whitespace changes to test fixtures, which
broke V8 tests. Revert those changes to fix our tests.

PR-URL: #32587
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
mmarchini committed Apr 1, 2020
1 parent 18b3383 commit f6dcd63
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ snippet: "
#d() { return 1; }
constructor() { (() => this)().#d(); }
}

var test = D;
new test;
"
Expand Down Expand Up @@ -147,3 +147,4 @@ constant pool: [
]
handlers: [
]

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ expression: new class { #method() { return 1; } get #accessor() { } set #accesso
[0] : {
name : #method
type : function
value :
value :
}
[1] : {
name : #accessor
Expand All @@ -21,7 +21,7 @@ expression: new class extends class { #method() { return 1; } } { get #accessor(
[0] : {
name : #method
type : function
value :
value :
}
[1] : {
name : #accessor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ at C (interpreted) (0:85):
globals: "global#0": 0 (number)
- scope (local):
locals: "i32_arg": 42 (number), "i32_local": 0 (number)
stack:
stack:
at B (liftoff) (0:76):
- scope (global):
globals: "global#0": 0 (number)
Expand All @@ -29,7 +29,7 @@ at A (liftoff) (0:54):
globals: "global#0": 0 (number)
- scope (local):
locals: "arg#0": 42 (number)
stack:
stack:
at (anonymous) (0:17):
- scope (global):
-- skipped globals
Expand All @@ -54,7 +54,7 @@ at A (liftoff) (0:54):
globals: "global#0": 0 (number)
- scope (local):
locals: "arg#0": 42 (number)
stack:
stack:
at (anonymous) (0:17):
- scope (global):
-- skipped globals
Expand All @@ -67,7 +67,7 @@ at C (interpreted) (0:89):
globals: "global#0": 42 (number)
- scope (local):
locals: "i32_arg": 42 (number), "i32_local": 0 (number)
stack:
stack:
at B (liftoff) (0:76):
- scope (global):
globals: "global#0": 42 (number)
Expand All @@ -79,7 +79,7 @@ at A (liftoff) (0:54):
globals: "global#0": 42 (number)
- scope (local):
locals: "arg#0": 42 (number)
stack:
stack:
at (anonymous) (0:17):
- scope (global):
-- skipped globals
Expand All @@ -104,7 +104,7 @@ at A (liftoff) (0:54):
globals: "global#0": 42 (number)
- scope (local):
locals: "arg#0": 42 (number)
stack:
stack:
at (anonymous) (0:17):
- scope (global):
-- skipped globals
Expand All @@ -117,7 +117,7 @@ at C (interpreted) (0:93):
globals: "global#0": 42 (number)
- scope (local):
locals: "i32_arg": 42 (number), "i32_local": 47 (number)
stack:
stack:
at B (liftoff) (0:76):
- scope (global):
globals: "global#0": 42 (number)
Expand All @@ -129,7 +129,7 @@ at A (liftoff) (0:54):
globals: "global#0": 42 (number)
- scope (local):
locals: "arg#0": 42 (number)
stack:
stack:
at (anonymous) (0:17):
- scope (global):
-- skipped globals
Expand Down
12 changes: 6 additions & 6 deletions deps/v8/test/inspector/runtime/evaluate-repl-await-expected.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ Tests that top-level await in Runtime.evaluate REPL mode includes stack trace.
callFrames : [
[0] : {
columnNumber : 0
functionName :
functionName :
lineNumber : 0
scriptId : <scriptId>
url :
url :
}
]
}
Expand Down Expand Up @@ -50,21 +50,21 @@ Tests that top-level await in Runtime.evaluate REPL mode includes stack trace.
functionName : bar
lineNumber : 2
scriptId : <scriptId>
url :
url :
}
[1] : {
columnNumber : 6
functionName : foo
lineNumber : 6
scriptId : <scriptId>
url :
url :
}
[2] : {
columnNumber : 4
functionName :
functionName :
lineNumber : 9
scriptId : <scriptId>
url :
url :
}
]
}
Expand Down

0 comments on commit f6dcd63

Please sign in to comment.