Skip to content

Commit f6b005d

Browse files
TrottBridgeAR
authored andcommitted
test: remove Windows skipping of http keepalive request GC test
Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think). PR-URL: #29354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 7a4ae1a commit f6b005d

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

test/parallel/test-http-server-keepalive-req-gc.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ const onGC = require('../common/ongc');
55
const { createServer } = require('http');
66
const { connect } = require('net');
77

8-
if (common.isWindows) {
9-
// TODO(addaleax): Investigate why and remove the skip.
10-
common.skip('This test is flaky on Windows.');
11-
}
12-
138
// Make sure that for HTTP keepalive requests, the req object can be
149
// garbage collected once the request is finished.
1510
// Refs: https://github.com/nodejs/node/issues/9668

0 commit comments

Comments
 (0)