From f5cadf6c1201dc95c416bca7c0cdb98bb1a0787e Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 14 Oct 2018 18:20:40 -0400 Subject: [PATCH] src: update v8::Object::GetPropertyNames() usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use the non-deprecated version of GetPropertyNames(). PR-URL: https://github.com/nodejs/node/pull/23660 Reviewed-By: Anna Henningsen Reviewed-By: Michaƫl Zasso Reviewed-By: Gus Caplan Reviewed-By: Sakthipriyan Vairamani Reviewed-By: James M Snell --- src/node_contextify.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 9c09bbb5fff3d1..c99f6c7ea5aef5 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -504,7 +504,12 @@ void ContextifyContext::PropertyEnumeratorCallback( if (ctx->context_.IsEmpty()) return; - args.GetReturnValue().Set(ctx->sandbox()->GetPropertyNames()); + Local properties; + + if (!ctx->sandbox()->GetPropertyNames(ctx->context()).ToLocal(&properties)) + return; + + args.GetReturnValue().Set(properties); } // static