Skip to content

Commit f571868

Browse files
gibfahnMylesBorins
authored andcommitted
build: fail linter if linting not available
PR-URL: #13658 Ref: #13645 (comment) Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent ef3698c commit f571868

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,7 @@ lint:
801801
@echo "Linting is not available through the source tarball."
802802
@echo "Use the git repo instead:" \
803803
"$ git clone https://github.com/nodejs/node.git"
804+
exit 1
804805

805806
lint-ci: lint
806807
endif

vcbuild.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ goto exit
360360
:no-lint
361361
echo Linting is not available through the source tarball.
362362
echo Use the git repo instead: $ git clone https://github.com/nodejs/node.git
363-
goto exit
363+
exit /b 1
364364

365365
:create-msvs-files-failed
366366
echo Failed to create vc project files.

0 commit comments

Comments
 (0)