Skip to content

Commit f4c3456

Browse files
Trottevanlucas
authored andcommitted
build: do not lint src dir for JS errors
There are no JavaScript files in the `src` directory. It can be safely omitted from the JavaScript linting step. PR-URL: #8128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4a8aca7 commit f4c3456

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -679,11 +679,11 @@ bench-idle:
679679
$(NODE) benchmark/idle_clients.js &
680680

681681
jslint:
682-
$(NODE) tools/jslint.js -J benchmark lib src test tools
682+
$(NODE) tools/jslint.js -J benchmark lib test tools
683683

684684
jslint-ci:
685685
$(NODE) tools/jslint.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
686-
benchmark lib src test tools
686+
benchmark lib test tools
687687

688688
CPPLINT_EXCLUDE ?=
689689
CPPLINT_EXCLUDE += src/node_root_certs.h

vcbuild.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,12 +348,12 @@ if defined jslint_ci goto jslint-ci
348348
if not defined jslint goto exit
349349
if not exist tools\eslint\lib\eslint.js goto no-lint
350350
echo running jslint
351-
%config%\node tools\jslint.js -J benchmark lib src test tools
351+
%config%\node tools\jslint.js -J benchmark lib test tools
352352
goto exit
353353

354354
:jslint-ci
355355
echo running jslint-ci
356-
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark lib src test tools
356+
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark lib test tools
357357
goto exit
358358

359359
:no-lint

0 commit comments

Comments
 (0)