Skip to content

Commit f4b766f

Browse files
addaleaxMyles Borins
authored and
Myles Borins
committed
streams: fix regression in unpipe()
Since 2e568d9 there is a bug where unpiping a stream from a readable stream that has `_readableState.pipesCount > 1` will cause it to remove the first stream in the `_.readableState.pipes` array no matter where in the list the `dest` stream was. This patch corrects that problem. PR-URL: #9171 Fixes: #9170 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 9f248a4 commit f4b766f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/_stream_readable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,7 @@ Readable.prototype.unpipe = function(dest) {
671671
if (index === -1)
672672
return this;
673673

674-
state.pipes.splice(i, 1);
674+
state.pipes.splice(index, 1);
675675
state.pipesCount -= 1;
676676
if (state.pipesCount === 1)
677677
state.pipes = state.pipes[0];

0 commit comments

Comments
 (0)