Skip to content

Commit f4377b1

Browse files
targosrichardlau
authored andcommitted
deps: V8: cherry-pick 7c182bd65f42
Original commit message: Fix visiblity rules for configs enforced by the latest GN version. Prior versions of GN had a bug (gn:22) where visibility rules for configs weren't being enforced properly. This CL tweaks the visibility settings of some configs to conform to the latest version. Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69463} Refs: v8/v8@7c182bd PR-URL: #39245 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent add7b5b commit f4377b1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.52',
37+
'v8_embedder_string': '-node.53',
3838

3939
##### V8 defaults for Node.js #####
4040

deps/v8/BUILD.gn

+8-4
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,8 @@ v8_toolset_for_shell = "host"
265265
#
266266

267267
config("internal_config_base") {
268-
visibility = [ ":*" ] # Only targets in this file can depend on this.
268+
# Only targets in this file and its subdirs can depend on this.
269+
visibility = [ "./*" ]
269270

270271
include_dirs = [
271272
".",
@@ -275,7 +276,8 @@ config("internal_config_base") {
275276

276277
config("internal_config") {
277278
defines = []
278-
visibility = [ ":*" ] # Only targets in this file can depend on this.
279+
# Only targets in this file and its subdirs can depend on this.
280+
visibility = [ "./*" ]
279281

280282
configs = [
281283
"//build/config/compiler:wexit_time_destructors",
@@ -361,7 +363,8 @@ config("v8_header_features") {
361363
# Put defines here that are only used in our internal files and NEVER in
362364
# external headers that embedders (such as chromium and node) might include.
363365
config("features") {
364-
visibility = [ ":*" ] # Only targets in this file can depend on this.
366+
# Only targets in this file and its subdirs can depend on this.
367+
visibility = [ "./*" ]
365368

366369
defines = []
367370

@@ -478,7 +481,8 @@ config("features") {
478481
}
479482

480483
config("toolchain") {
481-
visibility = [ ":*" ] # Only targets in this file can depend on this.
484+
# Only targets in this file and its subdirs can depend on this.
485+
visibility = [ "./*" ]
482486

483487
defines = []
484488
cflags = []

0 commit comments

Comments
 (0)